Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 17, 2025

This PR updates the deprecated Hermes API endpoints in PriceServiceConnection.ts to use the new v2 endpoints as documented in https://hermes.pyth.network/docs/#/.

Changes:

  • Replace /api/latest_price_feeds with /v2/updates/price/latest
  • Replace /api/latest_vaas with /v2/updates/price/latest
  • Replace /api/get_vaa with /v2/updates/price/{publish_time}
  • Replace /api/get_price_feed with /v2/updates/price/{publish_time}
  • Replace /api/price_feed_ids with /v2/price_feeds

Added deprecation notices to affected methods to warn users about potential response format changes.
Implemented response data transformation to maintain backward compatibility with existing method signatures.

Testing:

  • Verified all endpoint URLs against Hermes API documentation
  • Existing e2e tests pass as they verify response formats rather than specific URLs
  • No breaking changes to method signatures

Note: Cleaned up PR to only include changes to PriceServiceConnection.ts

Link to Devin run: https://app.devin.ai/sessions/dddc1fa287f048e48e27a69460564444

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:05pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:05pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 11:05pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 11:05pm
insights ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 11:05pm

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1737152496-update-hermes-api-endpoints branch from 46960b3 to 210b8de Compare January 17, 2025 22:27
@devin-ai-integration devin-ai-integration bot force-pushed the devin/1737152496-update-hermes-api-endpoints branch from 4e490b1 to 21b835b Compare January 17, 2025 22:46
@devin-ai-integration
Copy link
Contributor Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant